Repository navigation
Conversation
| <securecookie host="^readthedocs\.io" name=".+" /> | ||
|
|
||
| <rule from="^https?://(.+\.)?rtfd\.org/" to="https://$1readthedocs.org/" /> | ||
| <rule from="^https?://(.+\.)?rtfd\.org/" to="https://$1readthedocs.io/" /> |
There was a problem hiding this comment.
Should this be changed to:
<rule from="^http://(.+\.)?rtfd\.org/" to="https://$1readthedocs.io/" />
See #1327
|
I am not entirely sure what is CI check moaning about. Any hints? |
I think it has to do with https://github.com/patryk/https-everywhere/blob/patch-1/src/chrome/content/rules/ReadTheDocs.xml#L33 Try: |
|
@fuzzyroddis: Do you want me to squash PR first, or you will do it during merging (I believe GitHub supports it in UI)? |
|
I am just a contributor, not officially part of the HTTPS Everywhere project. |
| <securecookie host="^readthedocs\.io" name=".+" /> | ||
|
|
||
| <rule from="^https?://(.+\.)?rtfd\.org/" to="https://$1readthedocs.org/" /> | ||
| <rule from="^http://([\w-]+\.)?rtfd\.org/" to="https://$1readthedocs.io/" /> |
There was a problem hiding this comment.
This line is obsolete with the generic redirect below.
There was a problem hiding this comment.
Sadly rtfd.org does not support HTTPS however, so we need to redirect straight to https://$1readthedocs.io
|
|
|
Feedback has been addressed in #6242 |
…) (#6242) * new readthedocs.io domain * Remove HTTP/HTTPS redirects in line with #1327 * Fix for regex in readthedocs.io * [Read the Docs] Add tests, other minor updates. * Add tests * Expand <securecookie> coverage * Fix missing `$` in a <securecookie> * Move some tests around * Update comments * [Read the Docs] Fix the comment right this time
No description provided.